Enable bugprone-unchecked-optional-access clang-tidy check#1872
Closed
bavulapati wants to merge 8 commits intosourcemeta:mainfrom
Closed
Enable bugprone-unchecked-optional-access clang-tidy check#1872bavulapati wants to merge 8 commits intosourcemeta:mainfrom
bavulapati wants to merge 8 commits intosourcemeta:mainfrom
Conversation
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Member
|
Unless there is a case I missed and escaped the tests (could be?), I only assert when I'm sure that the optional is set because of some other pre-conditions, etc |
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Contributor
Author
|
@jviotti PTAL |
jviotti
approved these changes
Jul 28, 2025
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Member
|
Hey @bavulapati , I'm not sure that are you still working on these, so let me close them to reduce noise. Always feel free to re-open if you ever get back to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jviotti We are currently using assert before consuming std::optional's value.
The assert won't be present in production builds.
How should we handle this case? What to do in the case where optional doesn't have value?